Make shader write&read storage buffers match non readonly layouts #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After doing this, I realised that perhaps write-only storage buffers are not allowed in WGSL? From https://www.w3.org/TR/WGSL/#storage-buffer:
If so, should #2897 be closed instead? |
|
Welp, lets go ahead and merge this as it fixes the current behavior, thanks! But apparently they aren't anymore. There was never really a point, but whatever. Removing that is a separate issue. |
cwfitzgerald
requested changes
Jun 29, 2023
|
@cwfitzgerald Thanks for the feedback! I addressed your comments, you could re-review? |
teoxoy
added a commit
to teoxoy/wgpu
that referenced
this pull request
Jul 27, 2023
…outs (gfx-rs#3893)" This reverts commit 17143c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
See #2897, write-only storage buffer cannot match a Pipeline Layout.
Description
From the linked issue: When you provide a storage buffer pipeline layout with read-only set to false, if the shader marks the buffer is write, it will complain about a mismatched PLL and shader
Testing
Mark a storage storage buffer as
writein a shader, and use it with a buffer pipeline layout with read-only set to false. There is also a unit test of theaddress_space_matchesfunction.